Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Deprecate global Homebrew.args." #8234

Merged
merged 1 commit into from Aug 6, 2020

Conversation

MikeMcQuaid
Copy link
Member

Reverts #8216

This is causing issues in Homebrew/homebrew-test bot. These shouldn't be deprecated until all usages are removed in #8187 (so I'd suggest it's rolled into that).

CC @reitermarkus

@MikeMcQuaid MikeMcQuaid merged commit 4f502da into master Aug 6, 2020
@MikeMcQuaid MikeMcQuaid deleted the revert-8216-deprecate-global-args branch August 6, 2020 10:44
@reitermarkus
Copy link
Member

This is causing issues in Homebrew/homebrew-test bot.

Where?

@Bo98
Copy link
Member

Bo98 commented Aug 6, 2020

Because Homebrew.args is used in places in Homebrew/brew (fixed by #8187) that homebrew-test-bot invokes.

In the test-bot environment, all deprecations promoted to fatal errors.

e.g.

==> Using Homebrew/homebrew-test-bot a1f8223 (Merge pull request #462 from MikeMcQuaid/allowed_taps)

==> Running Formulae#detect_formulae!
==> Testing Homebrew/homebrew-core f917b657bfc (Merge dc7e4ba69f78c09f66ab3ede08c75304dcfc4d85 into 85250e720999af2009cdf2128d66bd30b75423ab):
    url             https://github.com/Homebrew/homebrew-core/pull/59205/checks
    origin/master   85250e72099 (ghc@8.6: add linux resource)
    HEAD            f917b657bfc (Merge dc7e4ba69f78c09f66ab3ede08c75304dcfc4d85 into 85250e720999af2009cdf2128d66bd30b75423ab)
    diff_start_sha1 85250e720999af2009cdf2128d66bd30b75423ab
    diff_end_sha1   f917b657bfccbc4951ac7083261b0c157d529973
/usr/local/Homebrew/Library/Homebrew/compat/cli/parser.rb:14:in `method_missing': Calling Homebrew.args is deprecated! Use `args = <command>_args.parse` and pass `args` along the call chain instead. (MethodDeprecatedError)
	from /usr/local/Homebrew/Library/Homebrew/help.rb:99:in `parser_help'
	from /usr/local/Homebrew/Library/Homebrew/help.rb:80:in `command_help'
	from /usr/local/Homebrew/Library/Homebrew/help.rb:61:in `help'
	from /usr/local/Homebrew/Library/Homebrew/brew.rb:141:in `rescue in <main>'
	from /usr/local/Homebrew/Library/Homebrew/brew.rb:38:in `<main>'

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 20, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants