Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile: drop sorbet environment #8261

Merged
merged 1 commit into from
Aug 9, 2020

Conversation

vidusheeamoli
Copy link
Contributor

@vidusheeamoli vidusheeamoli commented Aug 8, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We're now aiming on introducing developers to Sorbet, hence it seems like a good time to abandon ENV["HOMEBREW_SORBET"] in our Gemfile and introduce Sorbet.
cc - @issyl0 @mistydemeo

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a nice milestone!

@jonchang
Copy link
Contributor

jonchang commented Aug 9, 2020

Can this be unversioned like the rest of Gemfile, or are patch versions incompatible with each other?

@issyl0
Copy link
Member

issyl0 commented Aug 9, 2020

@jonchang This was pinned in #8055 because newer versions surface over 100 new typing errors in Tapioca's autogenerated RBI files which we can't do anything about. It's been a while now and Sorbet is on 0.5.5866, so I've done some investigation into how we can unpin this and get back to a sensible number of errors that are fixable. TL;DR on my draft PR: When Tapioca ships a new version, we'll be able to unpin this.

@issyl0 issyl0 merged commit e28a336 into Homebrew:master Aug 9, 2020
@MikeMcQuaid
Copy link
Member

@jonchang @issyl0 @vidusheeamoli What we should do is remove the version pinning from Gemfile and have something running in CI that ensures we don't merge upgrades that break things. If that's going to be more than a few days: we should add a comment to the Gemfile explaining why the pins is in place and what we're waiting on.

@vidusheeamoli vidusheeamoli deleted the sorbet-gemfile branch August 17, 2020 10:49
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 17, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants