Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language stanza to cask rubocops #8271

Merged
merged 1 commit into from
Aug 9, 2020

Conversation

waldyrious
Copy link
Contributor

@waldyrious waldyrious commented Aug 9, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

These changes have been split out from #8265. The language stanza should be in its own group, but current practice is to separate multiple language blocks with newlines, which contradicts the stanzas within the same group should have no lines between them rule in test/rubocops/cask/stanza_grouping_spec.rb. This PR is kept as a draft until a decision is made in how to address that. For example, we could:

  • Edit the casks in Homebrew/Homebrew-cask to remove the blank line between language blocks
  • Make an exception for the language stanza in the stanzas within the same group should have no lines between them rule
  • Keep the language stanza out of the sorting/grouping validation altogether (as it was before)
  • Something else

How should I proceed?

Also fix the corresponding test
@waldyrious
Copy link
Contributor Author

/cc @reitermarkus

@reitermarkus reitermarkus marked this pull request as ready for review August 9, 2020 23:08
@reitermarkus reitermarkus merged commit 264de96 into Homebrew:master Aug 9, 2020
@reitermarkus
Copy link
Member

Edit the casks in Homebrew/homebrew-cask to remove the blank line between language blocks

Done.

Thanks, @waldyrious!

@waldyrious
Copy link
Contributor Author

waldyrious commented Aug 10, 2020

That was fast! Thanks again for the quick merge and for editing the casks to match the rule :)

@waldyrious waldyrious deleted the add-language-stanza-group branch August 10, 2020 07:29
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 19, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants