New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global: tweak active_support requires. #8300
global: tweak active_support requires. #8300
Conversation
I was hoping that these would speed up boot but unfortunately they make no difference. They are a bit more minimal anyway so probably a good idea.
The problem I suspect is because The load path in brew is quite large, and that is what I wonder how much quicker things would be if we (for other requiring |
Yeh, I was thinking that too. Perhaps if we turned these all into Another option is extracting the actual logic we care about and vendoring that. |
Played around with the I didn't touch any taps however. |
Yeh, that doesn't sound like much. My guess is it may be the actual code that ActiveSupport is running rather than purely the |
There's other micro-optimisations like only requiring |
Cask commands are some of the biggest culprits of requiring half of Homebrew (I profiled |
I think |
Reducing the requires to just |
I was hoping that these would speed up boot but unfortunately they make no difference. They are a bit more minimal anyway so probably a good idea.
brew style
with your changes locally?brew tests
with your changes locally?