Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: fix input handling #8312

Merged
merged 1 commit into from Aug 12, 2020
Merged

Conversation

maxim-belkin
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

--prune flag expects an integer and when anything else is specified, it gets converted to 0 (args.prune&.to_i).
That implicit conversion to 0 made the integration test for cleanup that uses --prune=all to pass.

@Bo98
Copy link
Member

Bo98 commented Aug 11, 2020

--prune=all being supported is intentional, and used by others: https://github.com/search?l=Shell&q=%22brew+cleanup+--prune%3Dall%22&type=Code, as well as one of our own ops scripts.

@maxim-belkin
Copy link
Member Author

--prune=all being supported is intentional

all is not handled in any way -- any string has the same effect and is an equivalent to --prune=0. I can add support for "all" and revert changes to tests, if you think that's going to be useful.

@Bo98
Copy link
Member

Bo98 commented Aug 12, 2020

There used to be an explicit check for it but it disappeared in some refactoring - I don't think intentionally.

Library/Homebrew/test/cmd/cleanup_spec.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/cleanup.rb Outdated Show resolved Hide resolved
@maxim-belkin maxim-belkin merged commit e5e7a9a into Homebrew:master Aug 12, 2020
@maxim-belkin maxim-belkin deleted the fix-cleanup branch August 12, 2020 14:29
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 18, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants