Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/inreplace: add inreplace_pairs #8367

Merged
merged 1 commit into from Aug 17, 2020
Merged

utils/inreplace: add inreplace_pairs #8367

merged 1 commit into from Aug 17, 2020

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

MikeMcQuaid
MikeMcQuaid approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! Can be merged with comment addressed.

Library/Homebrew/utils/inreplace.rb Outdated
Pathname(path).atomic_write(contents.inreplace_string) unless read_only_run
contents.inreplace_string
end
module_function :inreplace_pairs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest just having module_function at the top of the module.

@SeekingMeaning SeekingMeaning merged commit 96fee49 into Homebrew:master Aug 17, 2020
@SeekingMeaning SeekingMeaning deleted the inreplace/inreplace_pairs branch August 17, 2020 17:19
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 17, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SeekingMeaning @MikeMcQuaid @BrewTestBot