Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

named args: Warn when user references a formula with the same name as a cask #8376

Merged
merged 2 commits into from Aug 18, 2020
Merged

named args: Warn when user references a formula with the same name as a cask #8376

merged 2 commits into from Aug 18, 2020

Conversation

whoiswillma
Copy link
Member

@whoiswillma whoiswillma commented Aug 17, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Print a warning/suggestion when a formula is referenced with the same name as a cask.

In brew home, when a user opens the homepage of a formula that has the same name as a cask, homebrew prints a helpful message telling the user to load the homepage of the cask using brew home homebrew/cask/<cask>. This PR generalizes that to all formula/keg/cask loading.

e.g. brew home crunch prints

Treating crunch as a formula. For the cask, use homebrew/cask/crunch
Opening homepage for Formula crunch

e.g. brew upgrade crunch prints

Treating crunch as a formula. For the cask, use homebrew/cask/crunch
Warning: crunch 3.6 already installed
Next Step

After this PR, I plan to submit a PR that adds commented-out deprecations for cask commands that have already been integrated with brew

@MikeMcQuaid MikeMcQuaid merged commit b932299 into Homebrew:master Aug 18, 2020
@MikeMcQuaid
Copy link
Member

Great work as usual @whoiswillma!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants