New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend/os/mac: install svn on catalina and newer #8383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does If so, do we still need a macOS-specific override for |
Also:
|
Sounds like the generic one here would work fine then: brew/Library/Homebrew/dependency_collector.rb Lines 62 to 66 in 42477a1
unless there's a reason it wasn't done before. |
MikeMcQuaid
approved these changes
Aug 18, 2020
chenrui333
added a commit
to chenrui333/homebrew-core
that referenced
this pull request
Aug 23, 2020
no need to specify svn dependency per Homebrew/brew#8383
chenrui333
added a commit
to chenrui333/homebrew-core
that referenced
this pull request
Aug 23, 2020
no need to specify svn dependency per Homebrew/brew#8383
chenrui333
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Aug 23, 2020
no need to specify svn dependency per Homebrew/brew#8383
chenrui333
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Aug 23, 2020
no need to specify svn dependency per Homebrew/brew#8383
chenrui333
added a commit
to chenrui333/homebrew-core
that referenced
this pull request
Aug 23, 2020
no need to specify svn dependency per Homebrew/brew#8383
5 tasks
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Aug 23, 2020
no need to specify svn dependency per Homebrew/brew#8383
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subversion is no longer available on Catalina and supposedly won't be available in newer macOS releases.
With this PR we can avoid specifying svn as build dependency, like here:
Homebrew/homebrew-core#59776
Failed workflow run (only on Catalina):
https://github.com/Homebrew/homebrew-core/runs/993661520?check_suite_focus=true#step:5:44
brew style
with your changes locally?brew tests
with your changes locally?