Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduled workflows: fix branch, add new files. #8421

Merged
merged 1 commit into from Aug 21, 2020

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Aug 21, 2020

  • ensure we reset to origin/master so we only have the commit we care
    about in the PR
  • ensure we git add to include any new files
  • don't use git commit -a and instead rely only on files added with git add

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

- ensure we reset to `origin/master` so we only have the commit we care
  about in the PR
- ensure we `git add` to include any new files
- don't use `git commit -a` and instead rely only on files added with
  `git add`
@MikeMcQuaid
Copy link
Member Author

#8423 was created from this and looks totally correct now @vidusheeamoli, @issyl0, @mistydemeo 🎉

@MikeMcQuaid MikeMcQuaid merged commit 85fe23e into master Aug 21, 2020
@MikeMcQuaid MikeMcQuaid deleted the spdx-tapioca-update branch August 21, 2020 16:15
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants