Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cask/cmd/zap: fix missing require #8440

Merged
merged 1 commit into from Aug 22, 2020
Merged

cask/cmd/zap: fix missing require #8440

merged 1 commit into from Aug 22, 2020

Conversation

miccal
Copy link
Member

@miccal miccal commented Aug 22, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Closes Homebrew/homebrew-cask#87959

Ping @Bo98

@Bo98
Copy link
Member

Bo98 commented Aug 22, 2020 •
edited

Unlike regular commands, cask commands are not lazily loaded so please move this inside def run.

cask/installer is a very heavy file which also does require "formula" along the line. brew tests --only=global should pick this up (let me know if it doesn't!).

@miccal
Copy link
Member Author

miccal commented Aug 22, 2020

Done, thank you for the quick review @Bo98.

This was referenced Aug 22, 2020
Merged
Closed
@Bo98
Copy link
Member

Bo98 commented Aug 22, 2020

Thanks!

@Bo98 Bo98 merged commit 6df7420 into Homebrew:master Aug 22, 2020
@miccal
Copy link
Member Author

miccal commented Aug 22, 2020

You are most welcome.

@miccal miccal deleted the cask_zap branch August 22, 2020 02:06
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew cask zap failed with error: uninitialized constant Cask::Cmd::Zap::Installer
3 participants
@miccal @Bo98 @BrewTestBot