Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled workflows fixes #8468

Merged
merged 1 commit into from Aug 24, 2020
Merged

Scheduled workflows fixes #8468

merged 1 commit into from Aug 24, 2020

Conversation

MikeMcQuaid
Copy link
Member

  • Ensure spdx.yml has same fixes as tapioca.yml.
  • Don't reset --hard to ensure that brew commands used are those in
    the same branch rather than always from origin/master
  • Don't check for an existing branch but instead force-push to it if
    there's any updates.
  • Provide sample brew typecheck command that can be used.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@dawidd6
Copy link
Member

dawidd6 commented Aug 24, 2020

Force push does not seem to work:
https://github.com/Homebrew/brew/pull/8468/checks?check_run_id=1021283749

@MikeMcQuaid
Copy link
Member Author

@dawidd6 this should fix it: Homebrew/actions#64

- Ensure `spdx.yml` has same fixes as `tapioca.yml`.
- Don't `reset --hard` to ensure that `brew` commands used are those in
  the same branch rather than always from `origin/master`
- Don't check for an existing branch but instead force-push to it if
  there's any updates.
- Provide sample `brew typecheck` command that can be used.
@MikeMcQuaid MikeMcQuaid merged commit 3b3b547 into master Aug 24, 2020
@MikeMcQuaid MikeMcQuaid deleted the scheduled-updates branch August 24, 2020 15:22
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 15, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants