Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fix Git error in tests. #8496

Merged
merged 2 commits into from Aug 29, 2020
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Aug 26, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@reitermarkus
Copy link
Member Author

@MikeMcQuaid, I think I found the right fix. We also need to clear the cache after each Git spec, not just before each one.

@reitermarkus reitermarkus force-pushed the debug-git branch 2 times, most recently from b900f5e to d10c8f8 Compare August 26, 2020 14:04
@reitermarkus reitermarkus marked this pull request as ready for review August 26, 2020 14:05
@MikeMcQuaid
Copy link
Member

@reitermarkus Thanks, sounds good. Can you also remove the HOMEBREW_TEST_GENERIC_OS addition?

@MikeMcQuaid
Copy link
Member

(or raise an exception in that case instead of unsetting)

@reitermarkus reitermarkus changed the title Reproduce Git error. Properly fix Git error in tests. Aug 27, 2020
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change 👏🏻

@reitermarkus reitermarkus merged commit a39aae8 into Homebrew:master Aug 29, 2020
@reitermarkus reitermarkus deleted the debug-git branch August 29, 2020 20:13
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants