Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metafiles: copy all license files #8499

Merged
merged 1 commit into from Aug 27, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Aug 26, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Relates to Homebrew/homebrew-core#60066

Metafiles.copy? now returns true for any file that starts with license. (or copying., copyright., licence.) . This means that files like COPYING.LESSER will be copied while they wouldn't be copied in the past.

I'm not sure if there are other license filename conventions we should include here as well.

Closes #8256

@reitermarkus
Copy link
Member

There is already a similar PR here: #8256

@Rylan12 Rylan12 mentioned this pull request Aug 27, 2020
6 tasks
@Rylan12
Copy link
Member Author

Rylan12 commented Aug 27, 2020

Thanks. Missed that...

I mentioned this issue there but I'm keeping this open for now as that PR hasn't been touched in a few weeks.

@MikeMcQuaid MikeMcQuaid merged commit 8d63afb into Homebrew:master Aug 27, 2020
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @Rylan12! I marked this as closing #8256 as it was failing CI and had no response.

@Rylan12 Rylan12 deleted the copy-license-metafiles branch August 27, 2020 13:08
@Rylan12
Copy link
Member Author

Rylan12 commented Aug 27, 2020

Thanks! I may open a follow up later to catch the LICENSE- case that was going to be fixed by #8256

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 15, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants