New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade: check for already broken dependents #8500
upgrade: check for already broken dependents #8500
Conversation
After upgrading a formula, it currently checks for broken dependents after upgrading any outdated dependents. If there are no outdated dependents, it exits early and doesn't check for broken dependents. This adds an earlier check for already broken dependents so they can be fixed even if there are no outdated dependents.
Yes, I think this would be desirable.
So this fix, if I understand correctly, is to fix the case where they haven't been broken by this This behaviour (and possibly your previous PR) may also warrant being added to Just to call it out: it does seem potentially surprising that this would start reinstalling things that are unrelated to anything that's being upgraded. I think it's still probably the right move but might want to improve the messaging. |
I moved the logic to a
That's correct
Yes, if we make this change we should improve the messaging. Alternatively, we could put this behavior in a separate command |
Let's try this out for now and see how people react. Thanks again @scpeters! |
thanks! |
Use `uniq` on the list of outdated dependents to remove duplicates, similar to a change made in Homebrew#8500.
brew style
with your changes locally?brew tests
with your changes locally?After upgrading a formula, it currently checks for broken dependents after upgrading any outdated dependents. If there are no outdated dependents, it exits early and doesn't check for broken dependents. This adds an earlier check for already broken dependents so they can be fixed even if there are no outdated dependents. (sorry that's kind of a mouthful)
I duplicated the block that checks for broken dependents; let me know if it should have its own method instead.
I haven't profiled this, but I expect it will perform linkage checks for dependents more often.