Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow platform in cask descriptions. #8557

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Don't allow platform in cask descriptions. #8557

merged 2 commits into from
Sep 1, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 1, 2020 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

All casks are for macOS, so this is useless information.

@reitermarkus reitermarkus mentioned this pull request Sep 1, 2020
Merged
MikeMcQuaid
MikeMcQuaid approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 nice!

Library/Homebrew/rubocops/shared/desc_helper.rb Outdated Show resolved Hide resolved
@reitermarkus @MikeMcQuaid
Switch unless to if.
f32b2e0 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@reitermarkus reitermarkus merged commit 50a9907 into Homebrew:master Sep 1, 2020
@reitermarkus reitermarkus deleted the desc-cop-macos branch September 1, 2020 12:42
@waldyrious
Copy link
Contributor

waldyrious commented Sep 1, 2020 •
edited
Loading

@reitermarkus in the spirit of this PR, shouldn't macOS be removed from VALID_LOWERCASE_WORDS at the start of desc_helper.rb? (Interestingly, it used to be the only item there, before #8333!)

@reitermarkus
Copy link
Member Author

It's still allowed in formula descriptions.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reitermarkus @waldyrious @MikeMcQuaid @BrewTestBot