Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask/installer: fix reference to opt_linked/optlinked #8565

Merged
merged 1 commit into from Sep 2, 2020

Conversation

SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Sep 1, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

opt_linked? does not exist and should instead be optlinked?

grep output for references to opt_linked:

$ grep -r 'opt_linked' .                 
./Library/Homebrew/cask/installer.rb:        installed && (cask_or_formula.respond_to?(:opt_linked?) ? cask_or_formula.opt_linked? : true)

Possible alternative:

  • Change this:
installed = if cask_or_formula.respond_to?(:any_version_installed?)
  cask_or_formula.any_version_installed?
else
  cask_or_formula.try(:installed?)
end
installed && (cask_or_formula.respond_to?(:opt_linked?) ? cask_or_formula.opt_linked? : true)
  • to this:
if cask_or_formula.is_a?(Formula)
  cask_or_formula.any_version_installed? && cask_or_formula.optlinked?
else
  cask_or_formula.installed?
end

@SeekingMeaning SeekingMeaning changed the title installer: fix reference to opt_linked/optlinked cask/installer: fix reference to opt_linked/optlinked Sep 1, 2020
@MikeMcQuaid
Copy link
Member

Good catch, thanks @SeekingMeaning!

@MikeMcQuaid MikeMcQuaid merged commit ea27822 into Homebrew:master Sep 2, 2020
@SeekingMeaning SeekingMeaning deleted the installer/optlinked branch September 2, 2020 16:25
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants