Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: make --dry-run conflict with --write #8606

Merged

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Related: #8177 (comment)

I'd expect --dry-run and --write to conflict and there to be a e.g. --no-commit if you want to avoid committing (this is also what brew bottle does with --write and --no-commit).

This PR keeps the existing behavior for --write, i.e. it does not perform any git operations by default. To create a commit without opening a pull request, we can use the new --commit switch

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, nice work 👍🏻

Also add `--commit` to a create commit without opening a pull request
@SeekingMeaning SeekingMeaning merged commit 2314ddf into Homebrew:master Sep 4, 2020
@SeekingMeaning SeekingMeaning deleted the bump-formula-pr/dry-run-write branch September 4, 2020 18:08
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants