Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash completion: Avoid cask deprecation warnings, learn --cask #8710

Merged

Conversation

Amorymeltzer
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As noted in #8709, this would remove some warnings in bash completion and make brew more aware of --cask when appropriate.

@reitermarkus reitermarkus requested a review from a team September 13, 2020 00:42
@reitermarkus reitermarkus added the cask Homebrew Cask label Sep 13, 2020
@reitermarkus reitermarkus merged commit bb07e91 into Homebrew:master Sep 13, 2020
@reitermarkus
Copy link
Member

Thanks, @Amorymeltzer!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants