Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running deprecated command in fish completion #8879

Merged
merged 1 commit into from Oct 8, 2020
Merged

Fix running deprecated command in fish completion #8879

merged 1 commit into from Oct 8, 2020

Conversation

aku11i
Copy link
Contributor

@aku11i aku11i commented Oct 8, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

A deprecated command is used in fish completion file.

How to occur the problem :

  • Open fish shell.
  • Type "brew cask uninstall " then press Tab.

image

@MikeMcQuaid MikeMcQuaid merged commit c31ce96 into Homebrew:master Oct 8, 2020
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @aktriver!

@aku11i aku11i deleted the fix-fish-completion branch October 8, 2020 16:01
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants