Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/github: paginate pull request commits API #8958

Merged
merged 1 commit into from Oct 20, 2020
Merged

utils/github: paginate pull request commits API #8958

merged 1 commit into from Oct 20, 2020

Conversation

jonchang
Copy link
Contributor

This is needed to run brew pr-pull on jumbo pull requests like Homebrew/homebrew-core#62560.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@jonchang jonchang mentioned this pull request Oct 20, 2020
Closed
MikeMcQuaid
MikeMcQuaid approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise 👍🏻

Library/Homebrew/utils/github.rb Outdated Show resolved Hide resolved
@jonchang
Copy link
Contributor Author

jonchang commented Oct 20, 2020 •
edited

Ok, this is updated. It'll raise early if it detects something wrong.

MikeMcQuaid
MikeMcQuaid approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks great.

@jonchang jonchang merged commit 4b6fe87 into Homebrew:master Oct 20, 2020
@jonchang jonchang deleted the paginate-pr-commits branch October 20, 2020 13:45
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonchang @MikeMcQuaid @BrewTestBot