Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for ARM #9067

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Fix test for ARM #9067

merged 1 commit into from
Nov 6, 2020

Conversation

fxcoudert
Copy link
Member

Fixes the following failure (#9066) on ARM Big Sur:

  1) Utils::Bottles#tag returns :catalina on Catalina
     Failure/Error: expect(described_class.tag).to eq(:catalina)
     
       expected: :catalina
            got: :arm64_catalina
     
       (compared using ==)
     
       Diff:
       @@ -1 +1 @@
       -:catalina
       +:arm64_catalina
       
     # ./test/utils/bottles/bottles_spec.rb:10:in `block (3 levels) in <top (required)>'
     # ./test/support/helper/spec/shared_context/homebrew_cask.rb:52:in `block (2 levels) in <top (required)>'
     # ./test/spec_helper.rb:194:in `block (3 levels) in <top (required)>'
     # ./test/spec_helper.rb:193:in `block (2 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'
     # ./vendor/bundle/ruby/2.6.0/gems/rspec-wait-0.0.9/lib/rspec/wait.rb:46:in `block (2 levels) in <top (required)>'

The test was somehow not updated when the tag for bottles was in #7942

@MikeMcQuaid MikeMcQuaid merged commit e18c0e4 into Homebrew:master Nov 6, 2020
@MikeMcQuaid
Copy link
Member

Thanks @fxcoudert!

@fxcoudert fxcoudert deleted the bs1 branch November 6, 2020 14:26
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants