Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type checking documentation. #9129

Merged
merged 3 commits into from
Dec 13, 2020
Merged

Improve type checking documentation. #9129

merged 3 commits into from
Dec 13, 2020

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Addresses part of #9099.

MikeMcQuaid
MikeMcQuaid reviewed Nov 13, 2020
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reitermarkus!

docs/Typechecking.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
docs/Typechecking.md Show resolved Hide resolved
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot
Copy link
Member

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale No recent activity label Dec 13, 2020
@reitermarkus
Copy link
Member Author

Merging this now. If there is anything still missing we can add it to #9099.

@reitermarkus reitermarkus merged commit ced0da1 into Homebrew:master Dec 13, 2020
@reitermarkus reitermarkus deleted the tc-docs branch December 13, 2020 03:23
@reitermarkus reitermarkus mentioned this pull request Dec 13, 2020
Closed
3 tasks
@MikeMcQuaid
Copy link
Member

Thanks @reitermarkus!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 14, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reitermarkus @BrewTestBot @MikeMcQuaid