Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checksum replacement in bump-cask-pr. #9246

Merged
merged 1 commit into from Nov 21, 2020
Merged

Fix checksum replacement in bump-cask-pr. #9246

merged 1 commit into from Nov 21, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Nov 21, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Fixes Homebrew/homebrew-cask#93256.

@BrewTestBot
Copy link
Member

Review period will end on 2020-11-24 at 18:08:58 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 21, 2020
@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Nov 21, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 21, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Nov 21, 2020 •
edited

Review period ended.

@miccal
Copy link
Member

miccal commented Nov 21, 2020

Thanks @reitermarkus -- you beat be to it! I was about to submit a PR for this.

@miccal
Copy link
Member

miccal commented Nov 21, 2020

Should be change the instances of brew cask audit and brew cask style with the new ones while we are at it?

@miccal miccal mentioned this pull request Nov 21, 2020
Closed
@reitermarkus
Copy link
Member Author

I have another branch already in progress where the remaining brew cask instances are replaced.

@reitermarkus reitermarkus merged commit b005770 into Homebrew:master Nov 21, 2020
@reitermarkus reitermarkus deleted the fix-bump-cask-pr-sha256 branch November 21, 2020 19:05
@korthout korthout mentioned this pull request Dec 8, 2020
Closed
6 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 22, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with bump-cask-pr and cask `sf-symbols'
3 participants
@reitermarkus @BrewTestBot @miccal