dev-cmd/unbottled: Fail nicely if HOMEBREW_NO_ANALYTICS is set

[issyl0]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?
• Have you successfully run brew man locally and committed any changes?

---

• When testing brew unbottled this crashed because I, as a maintainer, have HOMEBREW_NO_ANALYTICS set on all my machines to avoid polluting the analytics with test installs.

❯ brew unbottled
==> Getting formulae...
==> Getting analytics data...
Error: undefined method `[]' for nil:NilClass
/usr/local/Homebrew/Library/Homebrew/dev-cmd/unbottled.rb:89:in `formulae_all_sort_installs_from_args'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/unbottled.rb:49:in `unbottled'
/usr/local/Homebrew/Library/Homebrew/brew.rb:119:in `<main>'

[BrewTestBot]

Review period will end on 2020-11-27 at 16:59:22 UTC.

[issyl0]

Wait... maybe this was a red herring. Maybe it crashed because I didn't specify a formula (I assumed that brew unbottled worked like brew find-not-bottled in Homebrew/linux-dev in that it surfaced everything without a bottle). Either way there's something wrong, it just might not be exactly this fix.

[issyl0]

Turns out it does work like I thought it does (so this fix is good), I just read too fast! brew unbottled with no formula args (which is valid) does work on this branch whereas it doesn't on master.

[MikeMcQuaid]

I'd suggest instead checking for analytics.blank? in

brew/Library/Homebrew/dev-cmd/unbottled.rb

Line 88 in 86631b4

analytics = Utils::Analytics.formulae_brew_sh_json("analytics/install/90d.json")

and doing something like

raise UsageError, 
  "default sort by analytics data requires `HOMEBREW_NO_GITHUB_API` and `HOMEBREW_NO_ANALYTICS` to be unset!"

because the current conditions won't quite catch all the cases where this can occur.

[issyl0]

The review period works for better code! Thanks @MikeMcQuaid.

[MikeMcQuaid]

👍🏻 to 🚢 once typo change and brew style are fixed.

[BrewTestBot]

Review period ended.