Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Temporarily disable VERSIONED_KEG_ONLY_ALLOWLIST test" #9320

Closed
wants to merge 1 commit into from
Closed

Revert "Temporarily disable VERSIONED_KEG_ONLY_ALLOWLIST test" #9320

wants to merge 1 commit into from

Conversation

tschoonj
Copy link
Contributor

This reverts commit b2864fb.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@BrewTestBot
Copy link
Member

Review period will end on 2020-11-30 at 05:58:57 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 27, 2020
@jonchang
Copy link
Contributor

Cf. #9273

@jonchang jonchang added the critical Critical change which should be shipped as soon as possible. label Nov 27, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Nov 27, 2020 •
edited

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 27, 2020
@jonchang
Copy link
Contributor

Needs a linuxbrew merge before tests will pass.

@MikeMcQuaid
Copy link
Member

I believe @Rylan12 is already handling this in #9314.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tschoonj @BrewTestBot @jonchang @MikeMcQuaid