Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure default cask tap is installed on CaskUnavailableError. #9398

Merged
merged 2 commits into from
Dec 5, 2020
Merged

Ensure default cask tap is installed on CaskUnavailableError. #9398

merged 2 commits into from
Dec 5, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Dec 3, 2020 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Fixes Homebrew/homebrew-cask#94072.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-04 at 03:18:08 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 3, 2020
@reitermarkus reitermarkus force-pushed the cask-tap branch 4 times, most recently from a1a7dd5 to 5fc6432 Compare December 3, 2020 05:44
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 3, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 3, 2020 •
edited
Loading

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 3, 2020
@reitermarkus reitermarkus force-pushed the cask-tap branch 2 times, most recently from 29fa172 to db2c355 Compare December 5, 2020 02:28
@reitermarkus reitermarkus merged commit 1834a33 into Homebrew:master Dec 5, 2020
@reitermarkus reitermarkus deleted the cask-tap branch December 5, 2020 03:47
RandomDSdevel added a commit to RandomDSdevel/brew that referenced this pull request Dec 5, 2020
@RandomDSdevel
[Library/Homebrew/cli/named_args.rb] to_formulae_to_casks(): Reasso…
c237223 
…ciate its

`rescue` block with the right enclosing scope.

     PR Homebrew#9398 accidentally removed some semantically significant indentation in
this function, thus inadvertently kicking the `rescue` block inside out to func-
tion scope, when it moved its code further up in the file.  This may well not
confuse a Ruby interpreter, but it could trip human readers up.  Compensate and
correct the overlooked offending oversight and potential refactoring mistake by
restoring only that indentation, leaving the function in its new location.

Refs Homebrew#9398.
MikeMcQuaid
MikeMcQuaid reviewed Dec 7, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this!

Library/Homebrew/extend/os/mac/tap.rb Show resolved Hide resolved
@pgrenaud pgrenaud mentioned this pull request Dec 9, 2020
Closed
3 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 8, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"brew install --cask osxfuse" appears to be broken
3 participants
@reitermarkus @BrewTestBot @MikeMcQuaid