Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_macos/on_linux block: fix rubocop for special cases #9470

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

These should not be allowed:

  • Single SendNode that isn't depends_on/patch/resource/etc.
on_macos do
  desc "Collection of Linux utilities"
end
  • BlockNode that isn't depends_on/patch/resource/etc.
on_macos do
  bottle do
    cellar :any
  end

  depends_on "libcap"
end

Before:

% brew style util-linux

1 file inspected, no offenses detected

After:

% brew style util-linux
Library/Taps/homebrew/homebrew-core/Formula/util-linux.rb:19:3: C: on_macos can only include depends_on, patch and resource nodes.
  on_macos do ...
  ^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense auto-correctable

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-09 at 22:39:55 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 8, 2020
@reitermarkus
Copy link
Member

  on_macos do ...
  ^^^^^^^^^^^

Would be better to actually mark the node inside the block that is not allowed.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 10, 2020
@BrewTestBot
Copy link
Member

Review period ended.

@SeekingMeaning SeekingMeaning merged commit b3236ce into Homebrew:master Dec 10, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 10, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants