untap: add --force switch #9489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2020-12-10 at 21:52:38 UTC. |
BrewTestBot
added
the
waiting for feedback
dawidd6
force-pushed
the
untap-force
branch
2 times, most recently
from
583c622
to
717479d
Compare
I find this logic is inverse to anything else switched by |
|
We should make this:
|
Library/Homebrew/cmd/untap.rb
Outdated
| installed_tap_formulae = Formula.installed.select { |formula| formula.tap == tap } | ||
| installed_tap_casks = Cask::Caskroom.casks.select { |cask| cask.tap == tap } | ||
|
|
||
| if installed_tap_formulae.length.positive? || installed_tap_casks.length.positive? |
There was a problem hiding this comment.
Suggested change
| if installed_tap_formulae.length.positive? || installed_tap_casks.length.positive? | |
| if installed_tap_formulae.any? || installed_tap_casks.any? |
There was a problem hiding this comment.
Suggested change
| if installed_tap_formulae.length.positive? || installed_tap_casks.length.positive? | |
| if installed_tap_formulae.present? || installed_tap_casks.present? |
MikeMcQuaid
approved these changes
Dec 10, 2020
Library/Homebrew/cmd/untap.rb
Outdated
| installed_tap_formulae = Formula.installed.select { |formula| formula.tap == tap } | ||
| installed_tap_casks = Cask::Caskroom.casks.select { |cask| cask.tap == tap } | ||
|
|
||
| if installed_tap_formulae.length.positive? || installed_tap_casks.length.positive? |
There was a problem hiding this comment.
Suggested change
| if installed_tap_formulae.length.positive? || installed_tap_casks.length.positive? | |
| if installed_tap_formulae.present? || installed_tap_casks.present? |
Co-authored-by: Eric Knibbe <enk3@outlook.com>
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Dec 11, 2020
MikeMcQuaid
approved these changes
Dec 11, 2020
I disagree. The way this is implemented in the PR is consistent with how |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take on: #9422
Changes in comparison to previous PR:
if HOMEBREW_DEVELOPER env variable is set and there are tap formulae or casks installed, print warning instead of dying
assing formulae and casks name to variable, so we avoid duplicated logic
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run
brew stylewith your changes locally?Have you successfully run
brew testswith your changes locally?Have you successfully run
brew manlocally and committed any changes?