Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update livecheck strategies to avoid unnecessary redirections #9536

Merged
merged 2 commits into from Dec 15, 2020
Merged

Update livecheck strategies to avoid unnecessary redirections #9536

merged 2 commits into from Dec 15, 2020

Conversation

samford
Copy link
Member

@samford samford commented Dec 13, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This updates the page_url variables in the Hackage and Pypi livecheck strategies to avoid unnecessary redirections. The URLs are currently redirecting as follows:

  • https://hackage.haskell.org/package/Agda/src -> https://hackage.haskell.org/package/Agda/src/
  • https://pypi.org/project/Airshare#files -> https://pypi.org/project/Airshare/

page_url was missing the trailing forward slash in both of these cases. The Pypi page_url also includes the #files fragment but it's the missing forward slash, not the fragment, that causes the redirection.

These strategies currently function fine but #9535 made these redirections more apparent and it's always nice to avoid unnecessary redirections when we can.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-15 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 13, 2020
@samford samford changed the title Update livecheck strategies to avoid redirections Update livecheck strategies to avoid unnecessary redirections Dec 13, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 15, 2020
@BrewTestBot
Copy link
Member

Review period ended.

@samford samford merged commit 26a59c9 into Homebrew:master Dec 15, 2020
@samford samford deleted the update-livecheck-strategies-to-avoid-redirections branch December 15, 2020 00:22
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 14, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants