Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job: support Intel runners with -x86_64 in runner name #15

Merged
merged 2 commits into from
May 11, 2024
Merged

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented May 3, 2024

We currently download unneeded artifacts in CI runs because the glob
for, say, bottles_14* matches artifacts built on both Intel and M1
runners.

Adding the architecture to the runner name will allow us to use a more
specific glob which prevents needlessly downloading artifacts that we
won't use.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@carlocab carlocab marked this pull request as ready for review May 10, 2024 17:26
@carlocab carlocab requested a review from MikeMcQuaid May 10, 2024 17:26
src/job.rb Outdated Show resolved Hide resolved
@carlocab carlocab force-pushed the intel-runner-tag branch 2 times, most recently from 2fd99e8 to 4686f76 Compare May 11, 2024 17:40
carlocab and others added 2 commits May 12, 2024 01:43
We currently download unneeded artifacts in CI runs because the glob
for, say, `bottles_14*` matches artifacts built on both Intel and M1
runners.

Adding the architecture to the runner name will allow us to use a more
specific glob which prevents needlessly downloading artifacts that we
won't use.
Co-authored-by: Bo Anderson <mail@boanderson.me>
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 merged commit 74af280 into main May 11, 2024
4 checks passed
@Bo98 Bo98 deleted the intel-runner-tag branch May 11, 2024 18:01
carlocab added a commit to Homebrew/actions that referenced this pull request May 11, 2024
carlocab added a commit that referenced this pull request May 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants