-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Ability to disable vscode extension handling #1209
Comments
Thanks for the feedback. Is there a reason you would not like to dump your VSCode extensions also to your |
Don't uninstall all `vscode` extensions in this case. Fixes #1209
Yes... I use the built-in VSCode mechanism for managing extensions across multiple machines, most of which are not managed by a Brewfile. I might install or update an extension on a Linux or Windows machine and that will get applied to all other instances via the built-in synchronization. If I then ALSO have to remember to re-run the dump on the two machines where I do use a Brewfile or they get uninstalled (and thus REMOVED from all my other machines via the same built-in sync) it gets very tedious. |
Let's just say that the way I discovered this new feature was merged was mildly catastrophic, and if the built-in VSCode sync didn't have a way to revert to an old config I would be in much more trouble. |
It does, though, so you're not. I don't think saying "if it wasn't for a built-in feature in VSCode that predated this change this would have been very disruptive". I guess a "thanks for fixing my issue less than an 40 minutes after I opened it" was too much to ask here. Not sure why I bother sometimes, particularly when I'm on holiday/vacation. Enjoy using Homebrew! |
I'm not sure where the anger is coming from... You asked for my reasons and I simply provided them. I was unaware you were on vacation, so really that didn't enter my mind. I was certainly surprised that you fixed it so quickly, so a belated thank you for that. Perhaps I should have done that earlier, and that's certainly on me. I apologize for that. In any case, this was a catastrophic failure mode for a feature that didn't exist two days ago and was a surprise to anyone who routinely used |
If you feel that I was being belligerent in any way. I apologize. I certainly do appreciate the work done on Homebrew. |
No anger here ❤️
Much appreciated 🙇🏻 |
Don't uninstall all `vscode` extensions in this case. Fixes Homebrew#1209
I've been using a script for a very long time that installs items in my global Brewfile and then cleans up with
zap
after the fact. Now that it understands vscode extensions, it uninstalls every one of them each time I try to run it. I use the built-in vscode sync to keep extensions synced across multiple systems, not all of which are macOS/Homebrew managed.There should be a way to disable the management of vscode extensions so that users that don't want to use brew to manage them can still benefit from the cleanup commands without losing their setup every time.
The text was updated successfully, but these errors were encountered: