Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap to --json=v2 #821

Merged
merged 1 commit into from Nov 26, 2020
Merged

Swap to --json=v2 #821

merged 1 commit into from Nov 26, 2020

Commits on Nov 26, 2020

  1. Swap to --json=v2 

    Homebrew/brew@311c106 introduced a deprecation for using JSON output
with the v1 format so it's time to bump up to v2.

Looking over the occurrences and their usage, we should be 馃憣

```
$ rg -F "json=v1"
lib/bundle/locker.rb
90:        name_bottles = JSON.parse(`brew info --json=v1 --installed --quiet`)

lib/bundle/cask_dumper.rb
29:      cask_info_response = `brew info --cask #{cask_list.join(" ")} --json=v1`

spec/bundle/locker_spec.rb
73:        allow(locker).to receive(:`).with("brew info --json=v1 --installed --quiet").and_return <<~EOS

spec/bundle/cask_dumper_spec.rb
60:          .with("brew info --cask foo --json=v1")
73:          .with("brew info --cask foo --json=v1")
86:          .with("brew info --cask foo bar --json=v1")
```
    @jacobbednarz
    jacobbednarz committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    b3da7ad View commit details
    Browse the repository at this point in the history