Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Update flashforge-flashprint #1674

Merged

Conversation

suschizu
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

@suschizu suschizu closed this Jul 30, 2020
@suschizu suschizu reopened this Jul 30, 2020
@suschizu
Copy link
Contributor Author

 brew cask style36s
##[error]Process completed with exit code 1.
Run # don't care about `brew cask style` here.
Untapping adoptopenjdk/openjdk...
Untapped 37 casks (72 files, 406.5KB).
Error: Style check failed.
== /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask-drivers/Casks/caldigit-thunderbolt-charging.rb ==
C: 16:119: Line is too long. [160/118]

okay … and what can we do here?

@miccal
Copy link
Member

miccal commented Jul 31, 2020

This has been fixed by Homebrew/brew#8140 and #1675.

@suschizu
Copy link
Contributor Author

suschizu commented Jul 31, 2020

really? I thought this was a joke … so each url that is longer than 118 characters has to receive a line break?
seems that some people still have very small screens … so back to the 80ies :/

@suschizu
Copy link
Contributor Author

the lines in flashforge-flashprint aren#t too long - travis claims that some other casks has too long lines:

== /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask-drivers/Casks/canon-ijscanner4.rb ==
C: 10:119: Line is too long. [146/118]
C: 12:119: Line is too long. [172/118]
== /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask-drivers/Casks/canon-ijscanner5.rb ==
C: 10:119: Line is too long. [146/118]
C: 12:119: Line is too long. [172/118]
== /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask-drivers/Casks/canon-ijscanner6.rb ==
C: 10:119: Line is too long. [146/118]
C: 12:119: Line is too long. [172/118]
== /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask-drivers/Casks/microsoft-intellitype.rb ==
C:  9:119: Line is too long. [122/118]
== /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask-drivers/Casks/nvidia-web-driver.rb ==

@miccal
Copy link
Member

miccal commented Jul 31, 2020

All those ones have been fixed by the merging of Homebrew/brew#8140.

@miccal
Copy link
Member

miccal commented Jul 31, 2020

really? I thought this was a joke … so each url that is longer than 118 characters has to receive a line break?
seems that some people still have very small screens … so back to the 80ies :/

It is a GitHub thing.

@suschizu suschizu closed this Jul 31, 2020
@suschizu suschizu reopened this Jul 31, 2020
@miccal
Copy link
Member

miccal commented Jul 31, 2020

The last error will be fixed once #1675 is merged.

@vitorgalvao vitorgalvao merged commit 1c4ba08 into Homebrew:master Jul 31, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants