Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Update asix-ax88179 with macOS 11.0 driver #2231

Merged
merged 9 commits into from
May 24, 2021
Merged

Update asix-ax88179 with macOS 11.0 driver #2231

merged 9 commits into from
May 24, 2021

Conversation

ericswpark
Copy link
Contributor

Closes #2226

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Casks/asix-ax88179.rb Show resolved Hide resolved
Casks/asix-ax88179.rb Show resolved Hide resolved
@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label May 19, 2021
@vitorgalvao vitorgalvao mentioned this pull request May 19, 2021
6 tasks
@ericswpark
Copy link
Contributor Author

@vitorgalvao pushed another commit with your suggested changes, could you please take a look? Thanks.

@miccal miccal removed the awaiting user reply Issue needs response from a user. label May 20, 2021
Casks/asix-ax88179.rb Outdated Show resolved Hide resolved
@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label May 20, 2021
@vitorgalvao vitorgalvao removed the awaiting user reply Issue needs response from a user. label May 21, 2021
vitorgalvao
vitorgalvao previously approved these changes May 21, 2021
@vitorgalvao vitorgalvao enabled auto-merge (squash) May 21, 2021 20:45
@ericswpark
Copy link
Contributor Author

@vitorgalvao it seems like the SHA256 hash doesn't stay constant:
https://github.com/Homebrew/homebrew-cask-drivers/pull/2231/checks?check_run_id=2642746389

@vitorgalvao
Copy link
Member

it seems like the SHA256 hash doesn't stay constant:

Probably why it had the :no_check in the first place. You can revert that.

auto-merge was automatically disabled May 23, 2021 23:32

Head branch was pushed to by a user without write access

@ericswpark
Copy link
Contributor Author

Probably why it had the :no_check in the first place. You can revert that.

Done, just pushed the revert :)

@vitorgalvao vitorgalvao merged commit 910e71f into Homebrew:master May 24, 2021
@ericswpark ericswpark deleted the patch-1 branch May 25, 2021 02:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASIX AX88179 Big Sur drivers
3 participants