Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Add font-fira-code-regular-symbol #1873

Closed
wants to merge 1 commit into from
Closed

Add font-fira-code-regular-symbol #1873

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2019

Okay, new pull request! I think my Cask will now work.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

This font is a fallback font created by @siegebell last month and posted in this comment thread. Insofar as I can tell, it doesn't have a version, only a name.

Additionally, if adding a new cask:

@vitorgalvao
Copy link
Member

Thank you and welcome, but we’ll be rejecting this on account of not being notable enough:

That comment is three years old and there was never a request for the cask, which is a variant of an otherwise popular font. Having it unversioned and unofficial is a maintenance burden I don’t believe to be worth it.

@vitorgalvao vitorgalvao closed this Sep 2, 2019
@lock lock bot added the outdated label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants