This repository has been archived by the owner on May 16, 2024. It is now read-only.
Add the Octicons font #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| url 'https://github.com/github/octicons/archive/master.zip' | ||
| homepage 'https://octicons.github.com' | ||
| caveats "When using the GitHub logos, be sure to follow the GitHub logo guidelines (https://github.com/logos)" |
There was a problem hiding this comment.
This does not concern us. We’re not a discoverability service, so you should already know what you’re getting. caveats are for clarifications with installations, not usage. Please remove it.
There was a problem hiding this comment.
Thanks for the 👀. Removed via 65b79e1.
|
Could you please squash your commits? |
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds GitHub's Octicons font to Homebrew, literally, the only font I use which isn't already part of the cask.
To note, it will install off of
master, not truly the latest release.Fixes primer/octicons#70.
/cc @cameronmcefee