Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Create font-langdon.rb #945

Merged
merged 1 commit into from Jan 5, 2017
Merged

Create font-langdon.rb #945

merged 1 commit into from Jan 5, 2017

Conversation

miccal
Copy link
Member

@miccal miccal commented Jan 4, 2017

Repeat of #942 added to the right directory.

@vitorgalvao
Copy link
Member

We really need to fix that test to check for the correct directory.

@miccal miccal merged commit 865acaf into master Jan 5, 2017
@miccal miccal deleted the miccal-font-langdon branch January 5, 2017 00:39
@miccal
Copy link
Member Author

miccal commented Jan 5, 2017

Ping @jawshooah.

@jawshooah
Copy link
Contributor

Unfortunately I think someone else will have to take care of it if it needs taking care of sooner rather than later. I've had no time for OSS the past couple months, and that's not likely to change for a couple more 😞

My original attempt is here, but there were false positives so it was reverted here.

@miccal
Copy link
Member Author

miccal commented Jan 5, 2017

Thanks for your reply @jawshooah - unfortunately I am quite an amateur at Ruby (I do most of my coding in Maple and Matlab) but we will open an issue and hopefully get some help.

@jawshooah
Copy link
Contributor

You're in luck, the relevant code is actually just Bash 😉

@miccal
Copy link
Member Author

miccal commented Jan 5, 2017

Just as amateur in Bash!

@vitorgalvao
Copy link
Member

vitorgalvao commented Jan 5, 2017

I’m pretty competent with bash, but I cannot see what the problem is. I’m looking at it and everything looks fine.

We might have to merge that again just to see if I can diagnose the problem when it actually occurs.

@vitorgalvao
Copy link
Member

vitorgalvao commented Jan 5, 2017

It occurred to me the only thing that might be wrong there is Travis’ commit range, so I did some digging. Found this and this. Might be the solution.

@jawshooah
Copy link
Contributor

jawshooah commented Jan 5, 2017

From my comment on the original PR:

The problem is that git diff *.rb is pulling in files outside the current working directory. Using ./*.rb instead doesn't seem to change anything.

@vitorgalvao
Copy link
Member

The problem is that git diff *.rb is pulling in files outside the current working directory.

Not for me when testing locally. Might this have been something in git that changed since?

@vitorgalvao
Copy link
Member

Still running tests, but trying now with find to limit depth.

@vitorgalvao
Copy link
Member

Alright, it is done. Did a few tests in that PR (since squashed) to trigger failures and successes, and it seems to be working fine. Will merge and lets see.

tani pushed a commit to Homebrew/homebrew-linux-fonts that referenced this pull request Jan 27, 2018
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants