Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoa Rest HTTP software duplicate #1035

Closed
MunGell opened this issue Sep 16, 2013 · 4 comments
Closed

Cocoa Rest HTTP software duplicate #1035

MunGell opened this issue Sep 16, 2013 · 4 comments

Comments

@MunGell
Copy link
Contributor

MunGell commented Sep 16, 2013

Hi all,

I found duplicate of Cocoa Rest HTTP application in the repository.

The original link: http://code.google.com/p/cocoa-rest-client/

Cask brew output:

$ cask search rest
cocoa-rest-client   rest-client
$ cask info rest-client
cocoa-rest-client: 1.3.6
https://code.google.com/p/cocoa-rest-client/
Not installed
https://github.com/phinze/homebrew-cask/commits/master/Casks/cocoa-rest-client.rb
$ cask info cocoa-rest-client
cocoa-rest-client: 1.3.6
https://code.google.com/p/cocoa-rest-client/
Not installed
https://github.com/phinze/homebrew-cask/commits/master/Casks/cocoa-rest-client.rb

However, in source code they look fine:

https://github.com/phinze/homebrew-cask/blob/master/Casks/rest-client.rb
https://github.com/phinze/homebrew-cask/blob/master/Casks/cocoa-rest-client.rb

What could be an issue?

P.S. I have up-to-date version of Cask, just in case.

@passcod
Copy link
Contributor

passcod commented Sep 16, 2013

That's a fairly impressive oversight. @vitorgalvao which do you think should be clobbered ?

@phinze
Copy link
Contributor

phinze commented Sep 17, 2013

So I think this is actually a subtle bug in the Cask finding algorithm.

These are actually two different apps:

RESTClient is a Java application to test RESTful webservices.

https://code.google.com/p/rest-client/

CocoaRestClient is a Mac OS X app for testing HTTP/Restful endpoints.

https://code.google.com/p/cocoa-rest-client/

The problem is that cask info is not using an exact match algorithm. Seems to me like a valid bug.

@vitorgalvao
Copy link
Member

Yes, I remember these two (and checking the website for both, to make sure they were not the same app). I thought this over-zealous matching had been found and solved recently, so I was a bit confused, but I was thinking of something else.

phinze added a commit that referenced this issue Nov 6, 2013
fixes issue where casks with names that were a strict prefix of other
casks would always shadow them.

refs #1035
@phinze
Copy link
Contributor

phinze commented Nov 6, 2013

fixed the matching issue and this'll get included in the next release! 💇

@phinze phinze closed this as completed Nov 6, 2013
kevinSuttle pushed a commit to kevinSuttle/homebrew-cask that referenced this issue Dec 8, 2013
fixes issue where casks with names that were a strict prefix of other
casks would always shadow them.

refs Homebrew#1035
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants