Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casks still using SHA-1 #3372

Closed
30 tasks done
alebcay opened this issue Mar 4, 2014 · 7 comments
Closed
30 tasks done

Casks still using SHA-1 #3372

alebcay opened this issue Mar 4, 2014 · 7 comments

Comments

@alebcay
Copy link
Member

alebcay commented Mar 4, 2014

The current default behavior is for Casks to use a SHA-256 checksum instead of a SHA-1 checksum (this change occurred in v0.29.0, discussed in #2719). A handful of casks still use SHA-1. While this is not an immediate issue, it's probably a good idea to make them futureproof by updating them to SHA-256.


@rolandwalker
Copy link
Contributor

It's also my intention (with no specific timeline) to remove sha1 from the Cask DSL.

sha1 and no_checksum are just extra complexity: everything we need for the same functionality can be expressed as arguments to sha256.

@alebcay
Copy link
Member Author

alebcay commented Mar 5, 2014

Jaw drops Wow. Someone had a busy evening! Thanks @miguelfrde!

@miguelfrde
Copy link
Contributor

@alebcay A few ones are missing yet. Sage is still downloading and Sharetool throws a 500 server error.

Edit: sage is done

@alebcay
Copy link
Member Author

alebcay commented Mar 5, 2014

With ShareTool, the entire mirror site seems to be down. I'll see if I can find another download link.


EDIT: It seems ShareTool is undergoing a bit of change of ownership right now, and an update/download link will be available "soon".


EDIT AGAIN: I found a temporary mirror on CNET, but it's only 2.4.1, not 2.4.2, but I guess that'll have to do for now.

@rolandwalker
Copy link
Contributor

Note -- when I earlier did a mass update to use sha256, I rejected any download that didn't pass the existing sha1. Some of these group should be those cases.

It could easily be that something went wrong on my end during the original download, but it's worth double-checking. @alebcay I did manually check a number of your PRs that were only sha1->sha256 changes, and found nothing in error.

@tapeinosyne
Copy link
Contributor

Thanks @miguelfrde.

@vitorgalvao
Copy link
Member

Well, it seems it’s done. That was fast.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants