Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ARM64 builds of PHPStorm for Apple Silicon #100785

Merged
merged 4 commits into from Mar 8, 2021
Merged

Add support for ARM64 builds of PHPStorm for Apple Silicon #100785

merged 4 commits into from Mar 8, 2021

Conversation

hussainweb
Copy link
Contributor

@hussainweb hussainweb commented Mar 6, 2021

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

@hussainweb hussainweb changed the title Add support for ARM64 builds for Apple Silicon Add support for ARM64 builds of PHPStorm for Apple Silicon Mar 6, 2021
I am uncertain about the magic constants on the top of the file as I don't see them in other cask files I opened at random. Still, I am updating it because the linter has fixed it.
@hussainweb
Copy link
Contributor Author

I am uncertain about the magic constants on the top of the file as I don't see them in other cask files I opened at random. Still, I am updating it because the linter has fixed it.

@hussainweb
Copy link
Contributor Author

When running the brew style command locally, I see an error and I am not sure how to resolve it. Please let me know how I go about fixing that.

phpstorm.rb:4:1: C: Block has too many lines. [29/25]
cask "phpstorm" do ...
^^^^^^^^^^^^^^^^^^

@miccal
Copy link
Member

miccal commented Mar 8, 2021

Thank you @hussainweb.

@miccal miccal merged commit ca6a971 into Homebrew:master Mar 8, 2021
@hussainweb hussainweb deleted the patch-1 branch March 8, 2021 11:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants