Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crushftp from 9 to 10 #109237

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

FnControlOption
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

sha256 :no_check # required as upstream package is updated in-place

url "https://www.crushftp.com/CrushFTP#{version}_OSX.zip"
url "https://www.crushftp.com/early#{version}/CrushFTP#{version}.zip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't sound like a stable version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've written to CrushFTP's support and this is their answer:

Hi,

It's not early. We kept that naming convention from version 6 and so on.
It's in production at many companies already without issues.
They can use CrushFTP.com and go to the download page and download from there as well, even though in the backend it goes to the same location.
In 30 years of CrushFTP existence you are the first client to complain of that naming convention. :)
It might be some limitation of the application they use to get CrushFTP installed.
On what OS do they want to install CrushFTP under?

Thanks,
Arpad


To view ticket history please follow the link:
https://support.crushftp.com/support/ticket_g94hGE0htv4bES2v

sha256 :no_check # required as upstream package is updated in-place

url "https://www.crushftp.com/CrushFTP#{version}_OSX.zip"
url "https://www.crushftp.com/early#{version}/CrushFTP#{version}.zip",
cookies: { "CrushAuth" => "1234567890123_1234567890ABCDEFGHIJKLMNOPQRST" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this will work as it changes for each curl request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miccal @FnControlOption
From my testing, I could not get the download to complete locally with brew fetch

@FnControlOption
Copy link
Contributor Author

FnControlOption commented Sep 1, 2021

Waiting on Homebrew/brew#11790

@SMillerDev
Copy link
Member

It would still need to wait for that to make it into a release.

@miccal miccal merged commit 4d1112b into Homebrew:master Sep 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants