Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update leapp from 0.7.2 to 0.7.3 #112116

Closed
wants to merge 2 commits into from
Closed

Update leapp from 0.7.2 to 0.7.3 #112116

wants to merge 2 commits into from

Conversation

deiga
Copy link
Contributor

@deiga deiga commented Oct 5, 2021

Created with brew bump-cask-pr.

Change URL determining logic to match multi-url reality

@gdams
Copy link
Contributor

gdams commented Oct 5, 2021

This change seems kinda awkward to me (I understand the problem it solves). Is it worth us asking if the leapp developers will just create the versioned URL path when they release a new version?

@miccal
Copy link
Member

miccal commented Oct 6, 2021

Closing in favour of #112140.

@miccal miccal closed this Oct 6, 2021
@deiga
Copy link
Contributor Author

deiga commented Oct 6, 2021

@gdams Considering the limitations on url do blocks it makes sense to ask upstream devs to support the versioned URLs for latest versions as well

@deiga
Copy link
Contributor Author

deiga commented Oct 6, 2021

Filed upstream issue Noovolari/leapp#179

@deiga deiga deleted the bump-leapp-0.7.3 branch October 6, 2021 07:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants