New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitx: switch to maintained fork #141659
gitx: switch to maintained fork #141659
Conversation
Same questions/concerns as #89655.
|
Not only is gitx/gitx the only actively maintained fork, it's the only one that includes important fixes to work properly on Apple Silicon Macs. |
The point being made here is that if we update the cask to point to the new fork, then existing users will receive upgrades to the package that a different vendor now develops. Which is not a great experience for users, unless they are specifically intending to receive this change. Generally when a project is forked and becomes popular, (where appropriate) we would add a new cask with the vendor name as a suffix on the cask token. In this case that wouldn't be possible as the token would become |
Thanks for the reply @bevanjkay. That's a very reasonable concern. I still think it's too bad to leave users on such an old version with many bugs that have since been fixed. It seems like the best course then could be a new cask with a name like |
We can go about this in 2 different ways.
I am not one for deviating from normal policy, but I understand the needs of the community here. I think it would be wise to ask for a review from members of our Technical Steering Committee to help us make a final determination. |
Ping @Homebrew/tsc since I can't request an actual review for some reason. |
Reading the four links I provided above, I vote for option 1.
|
I am also leaning towards option 1 due to the benefits to the community and length of time upstream has been dead according to @hannesa2. I will wait to see what the TSC thinks though. |
Option 1 looks good. I think it’s not the first time we do this: at least we did that kind of thing in homebrew-core a few times and no-one has complained. The important thing to maybe check if there was a license change, but I guess there was none, so we should be good on that side. And if someone wants the legacy gitx back, we can still add a gitx-legacy package later on. |
We actually never do this (or at least never should) without the original author "blessing" the fork. In this case, though, the All that to say: I'm 👍🏻 in this case of landing this PR as-is. |
Homebrew/discussions#4250
#89655