rubocop: In-line disables for Style/{Class,Global}Vars
#142292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes RuboCop, that's because Homebrew/brew#14878 isn't merged yet. 🐔 🥚 |
issyl0
force-pushed
the
in-line-rubocop-disables
branch
from
e64b3e7
to
b58c668
Compare
issyl0
changed the title
Style/ClassVars disablesStyle/{Class,Global}Vars
|
Maybe just allow “Unnecessary disabling.” temporarily. |
reitermarkus
previously approved these changes
Mar 5, 2023
reitermarkus
added
the
ci-retry
|
/rebase |
- We're working to remove the global `Excludes:` from RuboCop configuration in `Homebrew/brew` (see issue 14685 over there). - This file in Cask was the only place where class vars weren't already in-line disabled. So, to be able to clean up the configuration stanza in Homebrew/brew (PR 14878), I've added some.
- We're working to remove the global `Excludes:` from RuboCop configuration in `Homebrew/brew` (see issue 14685 over there). - This file in Cask was the only place where global vars weren't already in-line disabled. So, to be able to clean up the configuration stanza in Homebrew/brew PR 14878, I've added some.
BrewTestBot
force-pushed
the
in-line-rubocop-disables
branch
from
b58c668
to
a4bdc10
Compare
BrewTestBot
removed
the
ci-retry
p-linnane
approved these changes
Mar 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excludes:from RuboCop configuration inHomebrew/brew(see issue 14685 over there).I feel like these scripts are ancient, but I'l leave deciding on cleanup to actual Cask maintainers!Nah, these aren't ancient, these are actually used! 😳 It's the ones indeveloper/cgithat looked ancient!Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask <cask>worked successfully.brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.