Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add caveats #146192

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

osalbahr
Copy link
Sponsor Contributor

The added caveat should clarify how to add the CLI tools after installing the cask.

Fixes #46078 (comment)

Commands log:

homebrew-cask$ brew audit --cask --online docker
==> Downloading https://desktop.docker.com/mac/main/amd64/106363/Docker.dmg
Already downloaded: /Users/osos/Library/Caches/Homebrew/downloads/a2fa53b312129a06f0f442d39dc52e4aa215dd8202dccd10ade7522d8fdd9584--Docker.dmg
homebrew-cask$ brew style --fix docker

1 file inspected, no offenses detected
homebrew-cask$ git branch
* add-docker-cli-caveat
master
homebrew-cask$ git status
On branch add-docker-cli-caveat
Your branch is up to date with 'origin/add-docker-cli-caveat'.

nothing to commit, working tree clean
homebrew-cask$ 

@osalbahr osalbahr marked this pull request as draft April 30, 2023 08:03
@osalbahr osalbahr marked this pull request as ready for review April 30, 2023 08:21
@osalbahr osalbahr changed the title Added docker CLI tools install caveat Add docker CLI tools install caveat May 1, 2023
@razvanazamfirei
Copy link
Member

/rebase

osalbahr and others added 2 commits May 4, 2023 02:02
The added caveat should clarify how to add the CLI tools after installing the cask.

Fixes [Homebrew#46078 (comment)](Homebrew#146078 (comment))
@razvanazamfirei razvanazamfirei changed the title Add docker CLI tools install caveat docker: add caveats May 4, 2023
@razvanazamfirei razvanazamfirei merged commit 19f5dfb into Homebrew:master May 4, 2023
13 checks passed
@@ -116,8 +116,14 @@
]

caveats <<~EOS
CLI tools are installed after launching Docker. They will be symlinked to one of the following
based on your preference:
Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your updated caveat. It's more concise and conveys more information.

I just tried to install the cask just to see how it would look like. Is the newline before "based" intended?

Screen Shot 2023-05-04 at 9 39 40 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Yes, the line break was intentional as not all terminals line-wrap. I'll change it in the next update so it breaks at 80 char instead of 100.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install both docker CLI and Docker app
3 participants