Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromedriver 115.0.5790.170 #152190

Merged
merged 2 commits into from Aug 8, 2023
Merged

chromedriver 115.0.5790.170 #152190

merged 2 commits into from Aug 8, 2023

Conversation

krehel
Copy link
Member

@krehel krehel commented Aug 2, 2023

Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Aug 2, 2023
@bevanjkay bevanjkay added ci-retry Continuously re-runs CI until it succeeds or is cancelled. ci-requeue Triggers a CI re-run when applied. labels Aug 3, 2023
@BrewTestBot BrewTestBot removed the ci-requeue Triggers a CI re-run when applied. label Aug 3, 2023
bevanjkay
bevanjkay previously approved these changes Aug 3, 2023
View reviewed changes
@krehel krehel marked this pull request as draft August 4, 2023 12:17
auto-merge was automatically disabled August 4, 2023 12:17

Pull request was converted to draft

@krehel krehel removed the ci-retry Continuously re-runs CI until it succeeds or is cancelled. label Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Aug 7, 2023
This was referenced Aug 7, 2023
Closed
Closed
@miccal
Copy link
Member

miccal commented Aug 7, 2023

/rebase

@github-actions github-actions bot removed the stale Issue which has not received any feedback for some time. label Aug 7, 2023
@BrewTestBot BrewTestBot force-pushed the bump-chromedriver-115.0.5790.170 branch from 9db69ee to da3e17d Compare August 7, 2023 09:39
@krehel krehel requested a review from a team August 7, 2023 13:44
@krehel
Copy link
Member Author

krehel commented Aug 7, 2023

I would appreciate someone else looking at this to find a path forward. Would ci-skip-install be valid here?

I tested this locally on both an ARM and intel machine and there are no issues running install or uninstall.

@p-linnane
Copy link
Member

Most of the Google casks need ci-skip-install because they try to remove shared services. I'm not sure that's what's happening here though.

@bevanjkay bevanjkay marked this pull request as ready for review August 8, 2023 02:55
@bevanjkay
Copy link
Member

@krehel @p-linnane Had to add removing the chromedriver symlink to the ci-cleanup step to allow for the install to proceed without error.

@krehel
Copy link
Member Author

krehel commented Aug 8, 2023

That's a brilliant catch there @bevanjkay!

@bevanjkay bevanjkay merged commit cdc6220 into Homebrew:master Aug 8, 2023
11 checks passed
@krehel krehel deleted the bump-chromedriver-115.0.5790.170 branch August 8, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bevanjkay bevanjkay bevanjkay approved these changes

Assignees
No one assigned
Labels
automerge-skip bump-cask-pr PR was created using `brew bump-cask-pr`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@krehel @miccal @p-linnane @bevanjkay @BrewTestBot