Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structuredlogviewer (new cask) #156909

Closed
wants to merge 2 commits into from

Conversation

jwosty
Copy link

@jwosty jwosty commented Oct 4, 2023

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Audit fails with a signature error because the author hasn't signed the app (see KirillOsenkov/MSBuildStructuredLog#686). There are no other errors.

audit for structuredlogviewer: failed
 - Signature verification failed:
/private/tmp/d20231004-26997-fa6qjl/StructuredLogViewer.app: rejected

macOS on ARM requires software to be signed.
Please contact the upstream developer to let them know they should sign and notarize their software.
structuredlogviewer
  * line 9, col 2: Signature verification failed:
    /private/tmp/d20231004-26997-fa6qjl/StructuredLogViewer.app: rejected
    
    macOS on ARM requires software to be signed.
    Please contact the upstream developer to let them know they should sign and notarize their software.
Error: 1 problem in 1 cask detected.

@BrewTestBot BrewTestBot added new cask missing zap Cask is missing a zap stanza, please add one. labels Oct 4, 2023
1 file inspected, no offenses detected
@jwosty
Copy link
Author

jwosty commented Oct 4, 2023

No zaps are necessary; the app does not create any files that need uninstalling.

@miccal
Copy link
Member

miccal commented Oct 4, 2023

Thank you for your submission @jwosty, but we cannot accept it at this time because it does not pass our signature verification check that are a requirement for new submissions:

macOS on ARM requires software to be signed. Please contact the upstream developer to let them know they should sign and notarize their software.

Please consider hosting this in your own Tap and if the developers sign their app in the future we would then be happy to consider adding this to homebrew-cask.

@miccal miccal closed this Oct 4, 2023
@jwosty
Copy link
Author

jwosty commented Oct 4, 2023

@miccal I see, thank you for letting me know. I've done this now (https://github.com/jwosty/homebrew-structuredlogviewer).

However the program can also be built as an executable with no app bundle - would distributing it as a formula be a viable alternative in the meantime, so users don't have to add a third-party tap?

@miccal
Copy link
Member

miccal commented Oct 5, 2023

However the program can also be built as an executable with no app bundle - would distributing it as a formula be a viable alternative in the meantime, so users don't have to add a third-party tap?

Yes, absolutely. Please feel free to submit a PR to the homebrew-core repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing zap Cask is missing a zap stanza, please add one. new cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants