Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci-skip-homepage label. #163916

Merged
merged 3 commits into from
Jan 7, 2024
Merged

Add ci-skip-homepage label. #163916

merged 3 commits into from
Jan 7, 2024

Conversation

reitermarkus
Copy link
Member

Goes together with Homebrew/brew#16438.

Alternatively, we could add a ci-skip-https label instead.

@reitermarkus reitermarkus marked this pull request as ready for review January 7, 2024 09:35
@reitermarkus
Copy link
Member Author

Merge together with Homebrew/brew#16438.

@reitermarkus reitermarkus mentioned this pull request Jan 7, 2024
9 tasks
@reitermarkus reitermarkus merged commit a88a7dc into master Jan 7, 2024
6 checks passed
@reitermarkus reitermarkus deleted the ci-skip-homepage branch January 7, 2024 15:35
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jan 8, 2024

Why would we want to skip the homepage as a one-off rather than fix the handling of the homepage so it doesn't error again next time?

@reitermarkus
Copy link
Member Author

We can't fix the homepage because it's gone.

fix the handling of the homepage so it doesn't error again

How would that look like? Completely ignoring the homepage audit for any deprecated/disabled cask?

@MikeMcQuaid
Copy link
Member

Completely ignoring the homepage audit for any deprecated/disabled cask?

This seems appropriate to me, yeah.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants