-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chatmate-for-facebook: remove #164497
chatmate-for-facebook: remove #164497
Conversation
459259c
to
9289533
Compare
We haven't to my knowledge used archive.org links for downloads in Cask. Is this something we are going to start doing? If the file is now only available in the App Store, I would vote for removal. From the Cask cookbook -
|
trying to bypass the homepage errors, it is already some practice in core though |
True, but those are built from source and can be patched as needed. To establish if there's a desire to use archive.org is a good question, though. Eventually any legacy software will have issues (not unlike the PPC binaries of yesteryear). |
There's about to be an audit to potentially remove wayback machine items from But does potentially allow for its use in |
it is transitional thing (as the interarchive formula/cask can be just deprecated) |
I'm also in favor of removing this.
|
I can remove it then. :) |
Signed-off-by: Rui Chen <rui@chenrui.dev>
9289533
to
5d79b17
Compare
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.https://apps.apple.com/us/app/chatmate-for-facebook/id1249947725?mt=12