Faster downloads for burp-suite and burp-suite-professional #168001
Conversation
|
Can you please split this to an individual PR for each cask? |
Casks/c/calibre.rb
Outdated
| url "https://download.calibre-ebook.com/#{version}/calibre-#{version}.dmg" | ||
| url "https://github.com/kovidgoyal/calibre/releases/download/v#{version}/calibre-#{version}.dmg", verified: "github.com/kovidgoyal/calibre/" |
There was a problem hiding this comment.
Monterey and older url are broken with this as upstream deletes attachments from GitHub.
Also, we will probably see someone open another issue/PR to switch it back, which is what happened in past:
- It's still a bad idea to rely on Github mirror for Calibre #104814
- Github mirror for Calibre is a bad idea #10039
The fun history of the cask:
There was a problem hiding this comment.
Yeah only the burp changes should be moved forward due to breakage of Calibre.
There was a problem hiding this comment.
Well, after reading all that, I should leave calibre as it is then, since it's going to be unreliable.
Thank you for letting me know about the history.
Looks like GitHub releases for calibre are unreliable, so gonna have just burp suite as part of this PR now. |
miccal
changed the title
Fixes #167997
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.